rust-diagnostics

This is a utility to insert diagnostics of code fragments as comments in Rust code and checks whether a warning/error in the diagnostics has been fixed in git commit history.

Rust compiler displays many diagnostics to the console, using file name and line numbers to indicate their exact locations. Without an IDE, it requires a programmer to go back and forth between command console and the editor.

This utility inserts the diagnostic messages in-place, which could enable transformer-based machine learning approaches to analyse Rust diagnostic semantics.

Through additional arguments, this utility also checks whether a warning found in revision r1 has been manually fixed by a revision r2.

Currently we integrate the utility with clippy and git-rs.

optional feature: fix

Automated fix of warnings by clippy could be recorded as transformations, including the programs before and after of fixes. Furthermore, scope of such transformations are narrowed down to the individual items, making it easier to spot whether the exact warnings get fixed or not. The remaining unfixed warnings are still kept in the transformed results.

Installation

bash cargo install rust-diagnostics

Usage:

bash rust-diagnostics [--patch <commit_id> [--confirm]]

Inserting warnings info into Rust code

The commented code is generated from the Rust code.

Note that this is a result of applying the utilility on its own implementation, i.e., eating our own dog food. We have manually resolved all the clippy warnings according to the specified clippy rules, except for the one on dbg_macro to show the results as an example:

```rust /#[Warning(clippy::dbg_macro)/dbg!(&r)/*

[Warning(clippy::dbg_macro)

note: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#dbgmacro the lint level is defined here ensure to avoid having uses of it in version control*/; `` contains aWarningas the diagnostic code, andclippy::dbgmacroas the name of the lint rule violated by the codedbg!(&msg)`.

Analyse the manually fixed warnings from change history

If you inspect the code and wonder whether revision r2 has fixed the warning of revision r1, you can use git log -p to identify the revisions' commit id first. Then run bash git checkout $r1 rust-diagnostics --patch $r2 --confirm The output includes the count of warnings of $r1 and the hunks between $r1..$r2 that matters to fix the warnings listed in front of the hunks.

(optional) Generating inputs and outputs of warning fixes by cargo clippy --fix

This requires that the 'fix’ feature being enabled when building the tool.

The code snippets before fix are listed as *.2.rs, and after fix are listed as *.3.rs under the transform/foo/ folder, where foo.rs is the Rust code that contains the fixed warnings.

(optional) Inherit Rustc flags to analyse diagnostics

This requires that the 'rustc_flags’ feature being enabled when building the tool.

Rustc flags used in .cargo/config are typically inherited by the cargo clippy. In this way one can avoid typing multiple -Wclippy::... options from the command line. Using rustc_flags feature it is possible to inherit them from the compiler options.

Updates (including bugfixes)

• [x] Insert two comments around the diagnositic spans;
• [x] Name the comments by the lint rules, and insert the rendered diagnostics into the second comment
• [x] Insert rendered diagnostic messages into the second comment.
• [x] Separate the output files into a different folder, so as to keep using the same ".rs" file extension
• [x] Measure the number of warnings per KLOC through count_diagnostics.sh
• [x] Store the transformation results before and after clippy --fix into the transform folder
• [x] list the marked rules applied to the transformations
• [x] Select only the relevant marked rules
• [x] List the fixed warnings and keep the remaining warnings in the output
• [x] Integrate with txl through txl-rs
• [x] Get RustCFlags from cargo
• [x] Call fix only when the number of warnings is larger than 0
• [x] Integrate with transformation systems to fix some of the warnings not yet fixed by clippy
• [x] Perform rustfmt to output of TXL transformations
• [x] Move the implementation of optional functionalities into rustc_flags, fix features to reduce the dependencies
• [x] Add a --patch <id> option to print out the patch of HEAD.. where is a commit id and HEAD is the current work tree
• [x] Make the --patch <id> feature to print out the patch of HEAD..
• [x] Print out the hunks only when they are relevant to the spans of warning locations
• [x] Add a --patch <id> --commit option to print out the hunks only when they have been fixed by the revision
• [ ] Add an option --pairs to generate diff records into code pairs
• [ ] Add an option -W to generate diff records with the surrounding function contexts (which was a feature of git diff but not supported by libgit2

Acknowledgement

• Thanks for David Wood, who offered the idea that we can use the --message-format=json option to get diagnostic information from the Rust compiler, which saves tremendous effort in modifying the Rust compiler. Now our solution is kind of independent from the Rust compiler implementations;
• Thanks for Mara Bos, who provided some hints on how to fix unwrap() warnings using if-let statements;
• Thanks for Amanieu d'Antras, who provided some explanation for the necessity of certain clippy rules in practice.